Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIRROR] Adds action & adjacent checks for mecha drill #2044

Merged
merged 1 commit into from
Feb 19, 2024

Conversation

Steals-The-PRs
Copy link
Collaborator

Mirrored on Nova: NovaSector/NovaSector#1035
Original PR: tgstation/tgstation#81530

About The Pull Request

  • Fixes #81527. Adds loc checks for every iteration of do_after_mecha() so if we move at any point (like in strife mode which slips by this proc) drilling stops. This calls action_checks() which uses power & does other integrity checks for every drill iteration like it should
  • Stops the mecha drill from using power & doing other checks if the target cannot be drilled

Changelog

🆑 SyncIt21
fix: mecha drill won't use power & do other checks if the target cannot be drilled.
fix: mecha drill will stop drilling if the mech moves even without changing direction. Also will use power & check other conditions every drill cycle.
/:cl:

* Adds action & adjacent checks for mecha drill (#81530)

## About The Pull Request
- Fixes #81527. Adds loc checks for every iteration of
`do_after_mecha()` so if we move at any point (like in strife mode which
slips by this proc) drilling stops. This calls `action_checks()` which
uses power & does other integrity checks for every drill iteration like
it should
- Stops the mecha drill from using power & doing other checks if the
target cannot be drilled

## Changelog
:cl:
fix: mecha drill won't use power & do other checks if the target cannot
be drilled.
fix: mecha drill will stop drilling if the mech moves even without
changing direction. Also will use power & check other conditions every
drill cycle.
/:cl:

* Adds action & adjacent checks for mecha drill

---------

Co-authored-by: SyncIt21 <[email protected]>
@Iajret Iajret merged commit d90a476 into master Feb 19, 2024
24 checks passed
@Iajret Iajret deleted the upstream-mirror-1035 branch February 19, 2024 17:57
AnywayFarus added a commit that referenced this pull request Feb 19, 2024
Iajret pushed a commit that referenced this pull request Apr 19, 2024
* calm not panik

* changes the access helper for that one door that for some reason was set to Syndicate Leader instead of general leading to someone being FORCED into a leadership spawn role if they ever want to go to the dock area.

* Update des_two.dmm

* coughs
ReezeBL pushed a commit that referenced this pull request Apr 19, 2024
* calm not panik

* changes the access helper for that one door that for some reason was set to Syndicate Leader instead of general leading to someone being FORCED into a leadership spawn role if they ever want to go to the dock area.

* Update des_two.dmm

* coughs

Co-authored-by: Zergspower <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants